olli/olli.puhakka.dev
Watch
1
0
Fork
You've already forked olli.puhakka.dev
 0
Code Issues 5 Pull requests Projects Releases Packages 2 Wiki Activity Actions

Drop a stray quote that broke the release check #25

Merged
olli merged 1 commit from fix/release-stray-quote into dev 2026-10-15 14:35:40 +03:00
Conversation 0 Commits 1 Files changed 1 +1 -1
olli-agent commented 2026-10-15 14:13:33 +03:00
Collaborator
Copy link

release.yml's find-image step has failed on every push to main since #21, most recently for 5770fee. When #21 changed the step to check both images, a stray " was left after the loop's done. YAML still parses it, but sh stops on the unterminated quote:

Syntax error: Unterminated quoted string

This removes the quote. Extracted from each version of the file, the step fails sh -n on dev and passes on this branch.

Production was never affected. The deployer follows main on its own, and https://olli.puhakka.dev serves 5770fee with the quiz API answering. Only the check that confirms a release was broken; it will pass again on the next push to main.

`release.yml`'s `find-image` step has failed on every push to `main` since #21, most recently for `5770fee`. When #21 changed the step to check both images, a stray `"` was left after the loop's `done`. YAML still parses it, but `sh` stops on the unterminated quote: ``` Syntax error: Unterminated quoted string ``` This removes the quote. Extracted from each version of the file, the step fails `sh -n` on `dev` and passes on this branch. Production was never affected. The deployer follows `main` on its own, and https://olli.puhakka.dev serves `5770fee` with the quiz API answering. Only the check that confirms a release was broken; it will pass again on the next push to `main`.
Drop a stray quote that broke the release check
All checks were successful
CI / lint (push) Successful in 2s
Details
CI / server (push) Successful in 23s
Details
CI / image (push) Successful in 3s
Details
CI / verify-staging (push) Successful in 41s
Details
5af8065221 
ffc1615 left a `"` after the find-image loop's `done`, so sh refused the
step ("unterminated quoted string") and Release run 49, the first since,
failed before checking anything. Production moved regardless: the
deployer does not wait for this job, only reports through it.
olli merged commit 5af8065221 into dev 2026-10-15 14:35:40 +03:00
olli deleted branch fix/release-stray-quote 2026-10-15 14:35:40 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
olli/olli.puhakka.dev!25
No description provided.